Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a chat review management system, adding API endpoints for a paginated review queue and review storage, along with corresponding repository methods and Pydantic schemas. Feedback identifies a security vulnerability where the administrator's ID is accepted from the request body; it is recommended to extract this information from the authentication token instead.
Comment on lines
+88
to
+93
| def save_admin_chat_review_api( | ||
| request: AdminChatReviewSaveRequest, | ||
| chat_log_id: int = Path(ge=1), | ||
| db: Session = Depends(get_db), | ||
| ) -> ApiResponse[AdminChatAdminReview]: | ||
| result = save_admin_chat_review(db, chat_log_id=chat_log_id, request=request) |
Contributor
There was a problem hiding this comment.
AdminChatReviewSaveRequest에서 admin_id를 클라이언트로부터 직접 입력받는 방식은 보안상 취약할 수 있습니다. 인증된 관리자가 다른 관리자의 ID로 리뷰를 저장하는 등의 오용을 방지하기 위해, admin_id는 require_admin_token 종속성을 통해 얻은 인증 정보에서 추출하여 서버 측에서 처리하는 것을 권장합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
유형
작업 내용
변경 사항 (있다면)
리뷰 포인트
테스트
/docs수동 확인pytest실행스크린샷